Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): Respond with bad json on signed requests [INGEST-407] #1090

Merged
merged 8 commits into from
Sep 28, 2021
Merged

fix(auth): Respond with bad json on signed requests [INGEST-407] #1090

merged 8 commits into from
Sep 28, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Sep 28, 2021 •
edited
Loading

Responds with 400 Bad Request and a descriptive error message when
sending invalid JSON payloads on endpoints requiring SignedJson.
Previously, this would just result in a misleading "invalid relay
signature" error.

@jan-auer jan-auer self-assigned this Sep 28, 2021
@jan-auer jan-auer marked this pull request as ready for review September 28, 2021 12:46
@jan-auer jan-auer requested a review from a team September 28, 2021 12:46
@jan-auer jan-auer merged commit cffbfaa into master Sep 28, 2021
@jan-auer jan-auer deleted the fix/ingest-407-bad-signature branch September 28, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @untitaker